Search on condition?

Questions specific to Megalogviewer

Moderator: LT401Vette

Post Reply
elaw
Super MS/Extra'er
Posts: 2926
Joined: Fri Oct 16, 2009 6:20 am
Location: Wilmington, MA

Search on condition?

Post by elaw »

Hey... have you ever considered adding a "search on condition" feature to MLV?

I'm going nuts trying to track down issues my car is having transitioning from overrun to idle. It would be tremendously helpful if I could do a search for "[RPM] > 1400 && [RPM] < 1600 && [TPS] < 0.3". Then I could just keep hitting F3 to see all the different times those conditions are met.
Eric Law
1990 Audi 80 quattro with AAN turbo engine: happily running on MS3+MS3X
2012 Audi A4 quattro, desperately in need of tweaking

Be alert! America needs more lerts.
LT401Vette
Super MS/Extra'er
Posts: 12697
Joined: Sat Jul 16, 2005 8:07 am
Location: Moorseville, NC
Contact:

Re: Search on condition?

Post by LT401Vette »

Agreed... Someone else requested this a couple days ago also.

Oddly enough when I went to the code, the menus were already there but commented out.
The final search method looked like this:

Code: Select all

    public boolean searchExpression(){
    	// implement this it would be handy
    }
So apparently I intended to put this years ago and didn't :-P

It is now implemented.
Phil Tobin
EFI Analytics, helping to simplify EFI
Next Generation tuning software.
Supporting all MegaSquirt versions and firmwares.
http://www.TunerStudio.com
http://www.efiAnalytics.com/MegaLogViewer/
Support the firmware running your engine:
http://www.msextra.com/doc/donations.html
elaw
Super MS/Extra'er
Posts: 2926
Joined: Fri Oct 16, 2009 6:20 am
Location: Wilmington, MA

Re: Search on condition?

Post by elaw »

Fantastic... thanks! :D
Eric Law
1990 Audi 80 quattro with AAN turbo engine: happily running on MS3+MS3X
2012 Audi A4 quattro, desperately in need of tweaking

Be alert! America needs more lerts.
elaw
Super MS/Extra'er
Posts: 2926
Joined: Fri Oct 16, 2009 6:20 am
Location: Wilmington, MA

Re: Search on condition?

Post by elaw »

Phil,

I just updated to 4.1.12 and found the "search by expression" function there... thanks!

There is however one little hiccup. If I use that function and find a point where the data matches, as soon as I try to reposition the cursor using the arrow keys it jumps back to where it was before I did the search. If I reposition the cursor with the mouse that does not happen.

Also not a bug but... it would be really cool if search expressions could be named and saved somehow... or even if it just remembered the last expression when you close the program.
Eric Law
1990 Audi 80 quattro with AAN turbo engine: happily running on MS3+MS3X
2012 Audi A4 quattro, desperately in need of tweaking

Be alert! America needs more lerts.
bkubisht
MS/Extra Newbie
Posts: 24
Joined: Fri Jul 18, 2014 1:54 pm

Re: Search on condition?

Post by bkubisht »

In addition to the quirk eLaw has regarding arrow keys... the custom expression search can't be repeated with F3. It just uses whatever the most recent non-custom expression search was.
Matt Cramer
Super MS/Extra'er
Posts: 17499
Joined: Thu Apr 16, 2009 8:08 pm

Re: Search on condition?

Post by Matt Cramer »

A search feature I'd like to have for composite logs would be to find the next point where it lost sync. That would be useful the next time I've got a comp log with 263 frames to look through. :)
Matt Cramer -1966 Dodge Dart slant six running on MS3X
LT401Vette
Super MS/Extra'er
Posts: 12697
Joined: Sat Jul 16, 2005 8:07 am
Location: Moorseville, NC
Contact:

Re: Search on condition?

Post by LT401Vette »

I'm glad you pulled up this old thread. Some how Eric's bug issue fell off my radar.

I have fixed that and fixed the F3 search next. It will be in the next release.

Matt, I will have a look at that as well, it does sound useful.
Phil Tobin
EFI Analytics, helping to simplify EFI
Next Generation tuning software.
Supporting all MegaSquirt versions and firmwares.
http://www.TunerStudio.com
http://www.efiAnalytics.com/MegaLogViewer/
Support the firmware running your engine:
http://www.msextra.com/doc/donations.html
Post Reply