knock log SD bug?

For discussion of Phil Tobin's Tuner Studio software (Only about the tuning software itself, not about how to tune or firmware features)

Moderator: LT401Vette

Post Reply
AbatelliCristian
Super MS/Extra'er
Posts: 855
Joined: Sun Oct 10, 2010 6:33 am

knock log SD bug?

Post by AbatelliCristian »

I see the difference between SD LOG an tunerstudio LOG for knock1 cyl1.
IN SD log, knock cyl1 is fix value....
configuration for lancia delta IAW.

James, I can't attach the log because is big for forum (isn't possible incrase the space at 1mb?).
I send you it, for email

thanks
jsmcortina
Site Admin
Posts: 39587
Joined: Mon May 03, 2004 1:34 am
Location: Birmingham, UK
Contact:

Re: knock log SD bug?

Post by jsmcortina »

Please also post or send the raw .MS3 logfile and the MSQ.

James
I can repair or upgrade Megasquirts in UK. http://www.jamesmurrayengineering.co.uk

My Success story: http://www.msextra.com/forums/viewtopic ... 04&t=34277
MSEXTRA documentation at: http://www.msextra.com/doc/index.html
New users, please read the "Forum Help Page".
AbatelliCristian
Super MS/Extra'er
Posts: 855
Joined: Sun Oct 10, 2010 6:33 am

Re: knock log SD bug?

Post by AbatelliCristian »

Ok, tunerstudio LOG is in your mail. Is big for forum.

In tunerstudio log is correct the value knock1, but in SD I see scorrect value.

Thanks
franksidebike
Experienced MS/Extra'er
Posts: 226
Joined: Fri Apr 08, 2005 2:08 pm
Location: Wathlingen, Germany

Re: knock log SD bug?

Post by franksidebike »

Hallo Christian
I have a similar problem with Egocor...., this help!
Please make a test.
In TS under SD Card Datalloging, Remove all (Strg+a) "Selected Datalog Fields", then make your Datalog Fields new.
Frank
jsmcortina
Site Admin
Posts: 39587
Joined: Mon May 03, 2004 1:34 am
Location: Birmingham, UK
Contact:

Re: knock log SD bug?

Post by jsmcortina »

This looks to be a conversion error. I'm sending a mail to Phil about it.

James
I can repair or upgrade Megasquirts in UK. http://www.jamesmurrayengineering.co.uk

My Success story: http://www.msextra.com/forums/viewtopic ... 04&t=34277
MSEXTRA documentation at: http://www.msextra.com/doc/index.html
New users, please read the "Forum Help Page".
AbatelliCristian
Super MS/Extra'er
Posts: 855
Joined: Sun Oct 10, 2010 6:33 am

Re: knock log SD bug?

Post by AbatelliCristian »

ok thanks
AbatelliCristian
Super MS/Extra'er
Posts: 855
Joined: Sun Oct 10, 2010 6:33 am

Re: knock log SD bug?

Post by AbatelliCristian »

other problem with sd card
I attach log msd and ms3 file....


You see AFR, boost duty.... and other value...
jsmcortina
Site Admin
Posts: 39587
Joined: Mon May 03, 2004 1:34 am
Location: Birmingham, UK
Contact:

Re: knock log SD bug?

Post by jsmcortina »

Is this still the same with the current TS beta ?

James
I can repair or upgrade Megasquirts in UK. http://www.jamesmurrayengineering.co.uk

My Success story: http://www.msextra.com/forums/viewtopic ... 04&t=34277
MSEXTRA documentation at: http://www.msextra.com/doc/index.html
New users, please read the "Forum Help Page".
LT401Vette
Super MS/Extra'er
Posts: 12697
Joined: Sat Jul 16, 2005 8:07 am
Location: Moorseville, NC
Contact:

Re: knock log SD bug?

Post by LT401Vette »

There have been no changes in regard to this in the beta.
Looking through the data, it looks as though a steady xE8 was logged. So the transformations are correct.

Based on what I have seen in the past, my guess would be that perhaps one of the logged OutputChannels changed and so the length set would be wrong. This would cause the firmware to log the incorrect number of bytes and shift all fields after.
This can be verified, it is just a bit of work to map all the logged offsets back to the ini definition and find the one that doesn't match.

If this is the case, doing as franksidebike said and removing the logged SD fields and re adding them will fix it.
Phil Tobin
EFI Analytics, helping to simplify EFI
Next Generation tuning software.
Supporting all MegaSquirt versions and firmwares.
http://www.TunerStudio.com
http://www.efiAnalytics.com/MegaLogViewer/
Support the firmware running your engine:
http://www.msextra.com/doc/donations.html
jsmcortina
Site Admin
Posts: 39587
Joined: Mon May 03, 2004 1:34 am
Location: Birmingham, UK
Contact:

Re: knock log SD bug?

Post by jsmcortina »

When I checked the log files posted the data appeared to match the size/offset headers in the .MS3 file, but it appeared to have transformed incorrectly?

James
I can repair or upgrade Megasquirts in UK. http://www.jamesmurrayengineering.co.uk

My Success story: http://www.msextra.com/forums/viewtopic ... 04&t=34277
MSEXTRA documentation at: http://www.msextra.com/doc/index.html
New users, please read the "Forum Help Page".
jsmcortina
Site Admin
Posts: 39587
Joined: Mon May 03, 2004 1:34 am
Location: Birmingham, UK
Contact:

Re: knock log SD bug?

Post by jsmcortina »

Looking through the data, it looks as though a steady xE8 was logged. So the transformations are correct.
That isn't what I found. 0xe8 is the second byte of EGOCOR (100.0% = 0x03e8) which is the byte that proceeds knock_cyl01. The byte that should be transformed to knock_cyl01 is 0x1a.

I see a potential issue that might be confusing TS?
Offset 86 :

Code: Select all

   cel_status        = scalar, U16,   86, "bit",   1.000, 0.0 ; engine fault bits
   cel_status_map    = bits,   U08,   87, [0:0] ; low byte
...
   cel_status_flex   = bits,   U08,   86, [0:0] ; high byte
...
Everything after this point in the log is off-by-one and corrupted.

The MSQ has two bytes set which matches the ini file and log file.

The data all looks to be in the correct place as far as I can tell comparing the hexdump of the MS3 file and the offsets/sizes in the ini file.

James
I can repair or upgrade Megasquirts in UK. http://www.jamesmurrayengineering.co.uk

My Success story: http://www.msextra.com/forums/viewtopic ... 04&t=34277
MSEXTRA documentation at: http://www.msextra.com/doc/index.html
New users, please read the "Forum Help Page".
LT401Vette
Super MS/Extra'er
Posts: 12697
Joined: Sat Jul 16, 2005 8:07 am
Location: Moorseville, NC
Contact:

Re: knock log SD bug?

Post by LT401Vette »

Yes I believe the double mapping to 2 different size fields is causing the problem.

It shouldn't be very difficult to add support for doing that.
Phil Tobin
EFI Analytics, helping to simplify EFI
Next Generation tuning software.
Supporting all MegaSquirt versions and firmwares.
http://www.TunerStudio.com
http://www.efiAnalytics.com/MegaLogViewer/
Support the firmware running your engine:
http://www.msextra.com/doc/donations.html
Post Reply