AC shows on in TS even when conditions turn it off

For discussion of Phil Tobin's Tuner Studio software (Only about the tuning software itself, not about how to tune or firmware features)

Moderator: LT401Vette

AC shows on in TS even when conditions turn it off

Postby jsdevel » Sat Oct 21, 2017 11:34 pm

In TS, whenever I have my AC switch turned on, the green light is on after the specified idle up delay, then it never turns off, even when I set min rpm artificially high and wait below that for a while. Is there a way to make the Green AC indicator in TS only come on when the AC output is actually on?
jsdevel
Experienced MS/Extra'er
 
Posts: 292
Joined: Mon May 23, 2016 3:41 pm
Location: Phoenix, AZ

Re: AC shows on in TS even when conditions turn it off

Postby LT401Vette » Sun Oct 22, 2017 5:03 am

:msq:

What firmware?
Phil Tobin
EFI Analytics, helping to simplify EFI
Next Generation tuning software.
Supporting all MegaSquirt versions and firmwares.
http://www.TunerStudio.com
http://www.efiAnalytics.com/MegaLogViewer/
Support the firmware running your engine:
http://www.msextra.com/doc/donations.html
User avatar
LT401Vette
Super MS/Extra'er
 
Posts: 10338
Joined: Sat Jul 16, 2005 8:07 am
Location: Moorseville, NC

Re: AC shows on in TS even when conditions turn it off

Postby jsdevel » Sun Oct 22, 2017 9:23 am

MS2/extra-3.4.2

Sent from my Nexus 6P using Tapatalk
jsdevel
Experienced MS/Extra'er
 
Posts: 292
Joined: Mon May 23, 2016 3:41 pm
Location: Phoenix, AZ

Re: AC shows on in TS even when conditions turn it off

Postby jsdevel » Mon Oct 23, 2017 1:15 am

So I looked at the source for the MS2/extra-3.4.2-release firmware, and I don't think this is an issue with TS. The AC status ligh does turn on and off when I flip the switch on and off. I think outpc.status3 &= ~STATUS3_ACOUT; needs to be added to the if (outpc.rpm < flash12.ac_idleup_min_rpm) { block inside the idle_ac_idleup function. I'm going to try this tomorrow to see if it works. Assuming I can get it to work by updating the firmware, should I take this over to the MS2/Extra development board?

Also, is it acceptable for me to copy bits from the source code here in the forums?
jsdevel
Experienced MS/Extra'er
 
Posts: 292
Joined: Mon May 23, 2016 3:41 pm
Location: Phoenix, AZ

Re: AC shows on in TS even when conditions turn it off

Postby jsdevel » Mon Oct 23, 2017 9:00 am

That did the trick! AC light shuts off now when min rpm threshold is reached. I'll report this in MS2/Extra Development. Sorry for the false alarm here. Issue filed in the MS2 Development board here.
jsdevel
Experienced MS/Extra'er
 
Posts: 292
Joined: Mon May 23, 2016 3:41 pm
Location: Phoenix, AZ


Return to Tuner Studio

Who is online

Users browsing this forum: Bing [Bot] and 2 guests