Potential Bug in MS3.INI & TS Translation Engine

For discussion of Phil Tobin's Tuner Studio software (Only about the tuning software itself, not about how to tune or firmware features)

Moderator: LT401Vette

Potential Bug in MS3.INI & TS Translation Engine

Postby Manu » Thu Dec 14, 2017 3:17 am

Hello,

While I was working on MS3 string translations, I found a potential BUG in MS3.ini files.

In MS3 Format 0566.05 Line 5241 :
Code: Select all
boost_ctl_cl_pwm_targs1 = "The best-estimate boost valve duty for target load vs. RPM. This allows you to 'kick-start' the closed-loop boost by setting the valve to the this position before engaging closed-loop PID control.\n\nThe table is initially determined by using "Setup Mode" and tuning as an open-loop table. Once the table is close enough, switch to 'Basic Mode' (or 'Advanced Mode') to enable the closed-loop control."


There are quotes inside the string. It's maybe not important when using TS in English. But from what I guess this can be a problem when using TS translation engine as this one seem to use Quotes to separate strings.

Thanks,
Manu
Last edited by Manu on Thu Dec 14, 2017 10:01 am, edited 1 time in total.
I can supply, repair or upgrade Megasquirts in FRANCE.

Image
https://www.megasquirt.fr
User avatar
Manu
Master MS/Extra'er
 
Posts: 409
Joined: Mon Feb 15, 2010 4:57 am
Location: Alès - France

Re: Potential Bug in MS3.INI

Postby jsmcortina » Thu Dec 14, 2017 4:40 am

Yes that's a bug. I would have thought that TunerStudio should warn about it.

James
I can supply, repair or upgrade Megasquirts in UK. http://www.jamesmurrayengineering.co.uk

My Success story: viewtopic.php?f=104&t=34277
MSEXTRA documentation at: http://www.msextra.com/doc/index.html
jsmcortina
Site Admin
 
Posts: 33991
Joined: Mon May 03, 2004 1:34 am
Location: Birmingham, UK

Re: Potential Bug in MS3.INI

Postby Manu » Thu Dec 14, 2017 9:07 am

Thanks,

Manu
Last edited by Manu on Thu Dec 14, 2017 9:31 am, edited 1 time in total.
I can supply, repair or upgrade Megasquirts in FRANCE.

Image
https://www.megasquirt.fr
User avatar
Manu
Master MS/Extra'er
 
Posts: 409
Joined: Mon Feb 15, 2010 4:57 am
Location: Alès - France

Re: Potential Bug in MS3.INI

Postby Manu » Thu Dec 14, 2017 9:31 am

Hi Phil,

while I translate MS3 sentence to French language I found some errors, the biggest one is describe below.

But I also found some limitations in the translation engine that lead in an inaccurate translation :

1 - It's case sensitive and that lead in many "double" strings in the database. It add many works in translations that can be avoid if TS wasn't case sensitive.
2 - The big problem is that TS match sentences. IMO this is not the better method to operate because MS firmware use similar sentences for many windows that, in French, can't be used like this. An accurate translation need to access each string in the window it belong to gain sense.

My thought is that rather to depend on sentences, TS translation engine will be better if it depend on labels. This way we can do accurate translations that match the field function rather than the sentence.

Best regards,
Manu
I can supply, repair or upgrade Megasquirts in FRANCE.

Image
https://www.megasquirt.fr
User avatar
Manu
Master MS/Extra'er
 
Posts: 409
Joined: Mon Feb 15, 2010 4:57 am
Location: Alès - France

Re: Potential Bug in MS3.INI & TS Translation Engine

Postby LT401Vette » Thu Dec 14, 2017 7:31 pm

A large majority of the text to be translated comes from the ini files. Without changing the ini's a lot there isn't a much we can do to change the way it works. It key's off the string as it is defined in the ini file.

Now for the translations from text in TunerStudio, there are 2 types:
- Static labels
- Dynamically generated strings.

TunerStudio is essentially leveraging the translation engine for the ini files to handle the static labels. The Dynamically generated strings do not have a proper solution and are doing the best they can with what is there.
Ideally the text would be pulled out to external bundles with tags for the dynamical components.
Putting in a proper solution for the dynamical text has been on the todo list for many years, but only so many hours in the day and a continuously growing todo list.

Now the idea of keying non-case sensitive would probably not be too bad. There could be some negative repercussions, but probably more good than bad. Or perhaps let it 1st check for a case sensitive match, if not found go for case insensitive.
Phil Tobin
EFI Analytics, helping to simplify EFI
Next Generation tuning software.
Supporting all MegaSquirt versions and firmwares.
http://www.TunerStudio.com
http://www.efiAnalytics.com/MegaLogViewer/
Support the firmware running your engine:
http://www.msextra.com/doc/donations.html
User avatar
LT401Vette
Super MS/Extra'er
 
Posts: 10409
Joined: Sat Jul 16, 2005 8:07 am
Location: Moorseville, NC

Re: Potential Bug in MS3.INI

Postby Manu » Fri Dec 15, 2017 3:01 am

Hi,

jsmcortina wrote:Yes that's a bug. I would have thought that TunerStudio should warn about it.

James


It will be useful to correct it in the current archive since this is the actual stable firmware and that it will last for months. Also change the TS downloadable .ini at server side will be good to.

Thanks,
Manu
I can supply, repair or upgrade Megasquirts in FRANCE.

Image
https://www.megasquirt.fr
User avatar
Manu
Master MS/Extra'er
 
Posts: 409
Joined: Mon Feb 15, 2010 4:57 am
Location: Alès - France

Re: Potential Bug in MS3.INI

Postby LT401Vette » Fri Dec 15, 2017 6:42 am

Manu wrote:Hi,


It will be useful to correct it in the current archive since this is the actual stable firmware and that it will last for months. Also change the TS downloadable .ini at server side will be good to.

Thanks,
Manu


I have updated the ini files on the server.
Phil Tobin
EFI Analytics, helping to simplify EFI
Next Generation tuning software.
Supporting all MegaSquirt versions and firmwares.
http://www.TunerStudio.com
http://www.efiAnalytics.com/MegaLogViewer/
Support the firmware running your engine:
http://www.msextra.com/doc/donations.html
User avatar
LT401Vette
Super MS/Extra'er
 
Posts: 10409
Joined: Sat Jul 16, 2005 8:07 am
Location: Moorseville, NC

Re: Potential Bug in MS3.INI & TS Translation Engine

Postby Manu » Fri Dec 15, 2017 12:12 pm

Thanks
I can supply, repair or upgrade Megasquirts in FRANCE.

Image
https://www.megasquirt.fr
User avatar
Manu
Master MS/Extra'er
 
Posts: 409
Joined: Mon Feb 15, 2010 4:57 am
Location: Alès - France


Return to Tuner Studio

Who is online

Users browsing this forum: No registered users and 3 guests