Support and discussion forum for Megasquirt 1, 2, 3, Microsquirt/module, DIYPNP, MSPNP2, MS3-Pro
https://www.msextra.com/forums/
I just got one to test the MS CAN output
The scaling factors I've seen so far can be quite cumbersome (including exponents and such) which would be difficult to expose. Simple add / multiply would be fine to expose.Peter Florance wrote:Will this stay hard coded in MS3 or will there be a point where ID's, data source and multipliers would be user-input?
I'm collecting and testing some BMW data.
Thanks
Code: Select all
case MSG_STD: // msg format 11 bit STD - do not let MSII mess with it
// reset identifier registers for standard ID
CAN_TB0_IDR0 = (unsigned char)(can[ix].cx_destvaroff[jx] >> 3);
// 8 high bits in IDR0, 3 low bits in IDR1
CAN_TB0_IDR1 = (unsigned char)((can[ix].cx_destvaroff[jx] & 0x0007) << 5);
CAN_TB0_IDR2 = (unsigned char)(0x00);
CAN_TB0_IDR3 = (unsigned char)(0x01);
CAN_TB0_DLR = (unsigned char) (can[ix].cx_varbyt[jx]);
for (kx = 0;kx < CAN_TB0_DLR;kx++) {
*(&CAN_TB0_DSR0 + kx) = can[ix].cx_datbuf[jx][kx];
}
break;Code: Select all
collect2: ld returned 1 exit status
make[1]: *** [ms2_extra.elf] Error 1
make[1]: Leaving directory `/home/artem/ms2extra_3.2.4_release/ms2extra'
make: *** [megasquirt] Error 2Code: Select all
for (kx = 0;kx < CAN_TB0_DLR;kx++) {
*(&CAN_TB0_DSR0 + kx) = can[ix].cx_datbuf[jx][kx];
}jsmcortina wrote:This code is already present in the current MS2/Extra pre-3.3 alpha code.
James
The solution is not what you're trying to do but to correct the alpha code setup. Make a new post on this and if there is a need to correct the code then it will be done. If the issue is a configuration then you will be able to correct it. And don't forget to post your msq and a log of the problem.acab wrote:On pre-3.3 alpha i cant get work ignition
its very hard to add code in 3.2.4?racingmini_mtl wrote: The solution is not what you're trying to do but to correct the alpha code setup. Make a new post on this and if there is a need to correct the code then it will be done. If the issue is a configuration then you will be able to correct it. And don't forget to post your msq and a log of the problem.
Jean
racingmini_mtl wrote:The thing is that if you have a genuine issue with the alpha code, it is very important that the developers know it and can correct it. Not posting about it makes sure that if there is a code issue it will not be corrected. That is a very bad way to handle a potential error and asking for help in the way you do is counter-productive.
Jean
But then start with the alpha code and add to that.acab wrote:racingmini_mtl wrote:The thing is that if you have a genuine issue with the alpha code, it is very important that the developers know it and can correct it. Not posting about it makes sure that if there is a code issue it will not be corrected. That is a very bad way to handle a potential error and asking for help in the way you do is counter-productive.
Jean
First of all, i wanna add own code for my dashboard (instead Audi\VW). And other...
Code: Select all
if (flash4.can_bcast1) {
id = Engine;
val_rpm = outpc.rpm * 1;
val_clt = (((outpc.clt - 320) * 5) / 9)/10 + 40;
dataLen = 0x08;
data[0] = 0x00;
data[1] = 0x00;
data[2] = 0x00;
data[3] = (unsigned char)val_clt; // CLT
data[4] = 0x00; // (fuel consumption) 0-132L L
data[5] = 0x00; // (fuel consumption) 0-132L H
data[6] = (unsigned char)(val_rpm / 32); //= RPM
data[7] = 0x00;
ECANSendMessage(id, data, dataLen, MSG_STD);
}
By now - CANBUS functionality work (may be) only for Audi\VW, i can add code for Fiat\Alfa\Lancia. But we must recode some for choice of car brand.Tjabo wrote:Seems like we have a failure to communicate here!
Are you guys saying that acab should properly report the problem with whatever is keeping his ignition from working in the new code, so that problem can be fixed in the new code and he can use the CANBUS facility in it? There must be a better way to say it that will translate more effectively...
For what it's worth, this CANBUS stuff could be super helpful when I can get to my e39 540i/6 project later in the spring. I'm excited!
Yes and the message is not going through at all. Once more the reply completely ignores this... I'm done trying.Tjabo wrote:Seems like we have a failure to communicate here!
Are you guys saying that acab should properly report the problem with whatever is keeping his ignition from working in the new code, so that problem can be fixed in the new code and he can use the CANBUS facility in it? There must be a better way to say it that will translate more effectively...
racingmini_mtl wrote: Yes and the message is not going through at all. Once more the reply completely ignores this... I'm done trying.
Jean
The single most important thing is to read, understand and take action on the replies that are posted on the forum.acab wrote:But what i must do, for add CANBUS code for my car?