New serial protocol / MS3 pre1.1 alpha codes 12+

Testing and development of Megasquirt 3

Moderators: jsmcortina, muythaibxr

jsmcortina
Site Admin
Posts: 39585
Joined: Mon May 03, 2004 1:34 am
Location: Birmingham, UK
Contact:

Re: New serial protocol

Post by jsmcortina »

The CRC is just of the payload. I'll email you some sample PC side code.

James
I can repair or upgrade Megasquirts in UK. http://www.jamesmurrayengineering.co.uk

My Success story: http://www.msextra.com/forums/viewtopic ... 04&t=34277
MSEXTRA documentation at: http://www.msextra.com/doc/index.html
New users, please read the "Forum Help Page".
prof315
Super MS/Extra'er
Posts: 3760
Joined: Sun Jan 18, 2009 3:13 am
Location: Melbourne, FL

Re: New serial protocol

Post by prof315 »

I just loaded alpha 12 and unfortuneately there seems to be an issue with CL pwm idle. My indicator says I am in CL idle ( TPS<1.5, VSS=0) but my IAC stays at the fully open position. If I shut the car off and restart it goes to cranking duty and stays there until I get out of CL and then goes fully open when it returns to CL.
Linfert Performance/321 Motorsports
SCCA 2019 SM National Champion Crew Chief
SCCA 2023 FP National Champion Tuner/electrical engineer
100s of MS systems built installed and tuned
Support the developers!
UnaClocker
Super MS/Extra'er
Posts: 1933
Joined: Fri May 07, 2004 12:59 pm
Location: Tacoma, WA
Contact:

Re: New serial protocol

Post by UnaClocker »

All seems well with Alpha 12. Future note, shut your hood before hot rodding around the neighborhood. Grrr.. :)
Brian
'84 Dodge Rampage
prof315
Super MS/Extra'er
Posts: 3760
Joined: Sun Jan 18, 2009 3:13 am
Location: Melbourne, FL

Re: New serial protocol

Post by prof315 »

UnaClocker wrote:All seems well with Alpha 12. Future note, shut your hood before hot rodding around the neighborhood. Grrr.. :)
I take it you're not using CL PWM idle.... Been there, done that with a CUSTOMER car before :o :cry:
Linfert Performance/321 Motorsports
SCCA 2019 SM National Champion Crew Chief
SCCA 2023 FP National Champion Tuner/electrical engineer
100s of MS systems built installed and tuned
Support the developers!
UnaClocker
Super MS/Extra'er
Posts: 1933
Joined: Fri May 07, 2004 12:59 pm
Location: Tacoma, WA
Contact:

Re: New serial protocol

Post by UnaClocker »

I'm using CL IAC. I did notice the idle was a bit high while I was forcing the hood shut at the end of the block, but that's pretty common after a reflash, it loses track of the stepper motor during the flash process. Two more restarts and it finally gets back into the normal operating range. I'll fire it up a couple more times. I see Alpha 11 made some PID changes, but only to the D term? I don't use D on my idle.. Seemed like the idle was fine on Alpha 11..
Brian
'84 Dodge Rampage
prof315
Super MS/Extra'er
Posts: 3760
Joined: Sun Jan 18, 2009 3:13 am
Location: Melbourne, FL

Re: New serial protocol

Post by prof315 »

Well I am absolutely sure I am seeing abnormal function of the CL PWM idle routine. I have had things factory perfect since James tweaked my firmware at the Megameet which was a not quite alpha 10.
Linfert Performance/321 Motorsports
SCCA 2019 SM National Champion Crew Chief
SCCA 2023 FP National Champion Tuner/electrical engineer
100s of MS systems built installed and tuned
Support the developers!
jsmcortina
Site Admin
Posts: 39585
Joined: Mon May 03, 2004 1:34 am
Location: Birmingham, UK
Contact:

Re: New serial protocol

Post by jsmcortina »

ms3_idle.c was only changed in relation to fan control and the AC button since the last alpha. Nothing else changed that I can see.

James
I can repair or upgrade Megasquirts in UK. http://www.jamesmurrayengineering.co.uk

My Success story: http://www.msextra.com/forums/viewtopic ... 04&t=34277
MSEXTRA documentation at: http://www.msextra.com/doc/index.html
New users, please read the "Forum Help Page".
prof315
Super MS/Extra'er
Posts: 3760
Joined: Sun Jan 18, 2009 3:13 am
Location: Melbourne, FL

Re: New serial protocol

Post by prof315 »

I'll try reflashing 12 and see what happens. But as of right now alpha 12 is giving me idle issues.
Linfert Performance/321 Motorsports
SCCA 2019 SM National Champion Crew Chief
SCCA 2023 FP National Champion Tuner/electrical engineer
100s of MS systems built installed and tuned
Support the developers!
jsmcortina
Site Admin
Posts: 39585
Joined: Mon May 03, 2004 1:34 am
Location: Birmingham, UK
Contact:

Re: New serial protocol

Post by jsmcortina »

Note that you will need to use the loader programme that comes with alpha12 (or use the boot jumper.)

James
I can repair or upgrade Megasquirts in UK. http://www.jamesmurrayengineering.co.uk

My Success story: http://www.msextra.com/forums/viewtopic ... 04&t=34277
MSEXTRA documentation at: http://www.msextra.com/doc/index.html
New users, please read the "Forum Help Page".
prof315
Super MS/Extra'er
Posts: 3760
Joined: Sun Jan 18, 2009 3:13 am
Location: Melbourne, FL

Re: New serial protocol

Post by prof315 »

I have been using the loader included with alpha 12. I do this with all of the alpha releases. I'm attaching another datalog. It starts with key on engine off and follows through to engagement of CL idle when DC goes from cranking DC to full open DC. There are breaks because I tried going inverted and then back to normal PWM IAC operation. And just a note about using inverted operation... the DC still went to 69.1% but the idle was 600 rpms instead of 2400.

All of this was done after reflashing with alpha 12 again. This time since the serial protocol did not change, things went faster and the msq was preserved. The msq was not preserved when flashing from alpha 11 to alpha 12.
Linfert Performance/321 Motorsports
SCCA 2019 SM National Champion Crew Chief
SCCA 2023 FP National Champion Tuner/electrical engineer
100s of MS systems built installed and tuned
Support the developers!
muythaibxr
Site Admin
Posts: 8228
Joined: Thu Oct 14, 2004 12:48 pm

Re: New serial protocol

Post by muythaibxr »

As James says, nothing in the idle code has really changed since the last alpha, so most likely, this is a settings problem or similar.

PID might need a retune if it's been a few alphas since you updated.

Ken
Megasquirt is not for use on pollution controlled vehicles. Any advice I give is for off road use only.
muythaibxr
Site Admin
Posts: 8228
Joined: Thu Oct 14, 2004 12:48 pm

Re: New serial protocol

Post by muythaibxr »

Looking at the settings, I don't see anything blatantly wrong.

However, I'm also not finding any code changes since the last alpha that would explain your issue.

Did you verify all your settings?

Ken
Megasquirt is not for use on pollution controlled vehicles. Any advice I give is for off road use only.
prof315
Super MS/Extra'er
Posts: 3760
Joined: Sun Jan 18, 2009 3:13 am
Location: Melbourne, FL

Re: New serial protocol

Post by prof315 »

muythaibxr wrote:Looking at the settings, I don't see anything blatantly wrong.

However, I'm also not finding any code changes since the last alpha that would explain your issue.

Did you verify all your settings?

Ken
All of my settings appear to be good. I'll triple check them but I still don't get why the idle DC is going to wide open upon CL engagement. It's quite clear in the datalog or should be as I can watch it happen on my TS dash. The settings are the same ones that provided a factory quality idle in alpha 11.
Linfert Performance/321 Motorsports
SCCA 2019 SM National Champion Crew Chief
SCCA 2023 FP National Champion Tuner/electrical engineer
100s of MS systems built installed and tuned
Support the developers!
prof315
Super MS/Extra'er
Posts: 3760
Joined: Sun Jan 18, 2009 3:13 am
Location: Melbourne, FL

Re: New serial protocol

Post by prof315 »

And please note I'm not bitching, just trying to report observed changes in the latest alpha, if you need anything specific just ask and I'll do my best to provide it.
Linfert Performance/321 Motorsports
SCCA 2019 SM National Champion Crew Chief
SCCA 2023 FP National Champion Tuner/electrical engineer
100s of MS systems built installed and tuned
Support the developers!
prof315
Super MS/Extra'er
Posts: 3760
Joined: Sun Jan 18, 2009 3:13 am
Location: Melbourne, FL

Re: New serial protocol

Post by prof315 »

I'm guessing that I'll need to use the bootloader to backdate to alpha 11? I had to drop my open DC to 41% to make the car drivable ( and I had to drive it today it's raining).
Linfert Performance/321 Motorsports
SCCA 2019 SM National Champion Crew Chief
SCCA 2023 FP National Champion Tuner/electrical engineer
100s of MS systems built installed and tuned
Support the developers!
jsmcortina
Site Admin
Posts: 39585
Joined: Mon May 03, 2004 1:34 am
Location: Birmingham, UK
Contact:

Re: New serial protocol

Post by jsmcortina »

To backdate to alpha 11 you don't need to use the boot jumper, but be sure to use the _new_ firmware loader programme. (It should be compatible with old and new codes.)

James
I can repair or upgrade Megasquirts in UK. http://www.jamesmurrayengineering.co.uk

My Success story: http://www.msextra.com/forums/viewtopic ... 04&t=34277
MSEXTRA documentation at: http://www.msextra.com/doc/index.html
New users, please read the "Forum Help Page".
prof315
Super MS/Extra'er
Posts: 3760
Joined: Sun Jan 18, 2009 3:13 am
Location: Melbourne, FL

Re: New serial protocol

Post by prof315 »

It took 2 tries to get alpha 11 loaded back up (using the new firmware loader) but now that I have, CL idle is functioning again. The first attempt at loading alpha 11 dropped out during the middle of the reflash (the program closed itself halfway through the process) but the second attempt worked.
Linfert Performance/321 Motorsports
SCCA 2019 SM National Champion Crew Chief
SCCA 2023 FP National Champion Tuner/electrical engineer
100s of MS systems built installed and tuned
Support the developers!
UnaClocker
Super MS/Extra'er
Posts: 1933
Joined: Fri May 07, 2004 12:59 pm
Location: Tacoma, WA
Contact:

Re: New serial protocol

Post by UnaClocker »

I can confirm that the closed loop idle is not working. I have a datalog with it. It's kind of a long datalog, so I tagged it twice at one point where I was idling. There are plenty of other idle points in the DL if you go digging for them. I had a P of 20, I think, I of 90, which I raised to 120 with no change, and no D term. But I'll attach my MSQ as well for you to examine.
Brian
'84 Dodge Rampage
jsmcortina
Site Admin
Posts: 39585
Joined: Mon May 03, 2004 1:34 am
Location: Birmingham, UK
Contact:

Re: New serial protocol

Post by jsmcortina »

That's most odd.
Since alpha11 there was as small code commit from Ken and then the radical changes to serial. Neither look to do anything that should impact idle.
However, to be methodical and narrow this down, I've sent some intermediate test code to Brian and Jeff.

James
I can repair or upgrade Megasquirts in UK. http://www.jamesmurrayengineering.co.uk

My Success story: http://www.msextra.com/forums/viewtopic ... 04&t=34277
MSEXTRA documentation at: http://www.msextra.com/doc/index.html
New users, please read the "Forum Help Page".
prof315
Super MS/Extra'er
Posts: 3760
Joined: Sun Jan 18, 2009 3:13 am
Location: Melbourne, FL

Re: New serial protocol

Post by prof315 »

I just loaded the test code James sent and it solved the problem. CL idle is functioning correctly.

Jeff
Linfert Performance/321 Motorsports
SCCA 2019 SM National Champion Crew Chief
SCCA 2023 FP National Champion Tuner/electrical engineer
100s of MS systems built installed and tuned
Support the developers!
Post Reply