MS3 1.2.3 source code released

Post by **jsmcortina** » Fri Jun 21, 2013 12:42 pm

To announce the release of source code for MS3 1.2.3

Be sure to read and respect the included README and LICENSE files.

http://www.msextra.com/doc/ms3/files/so ... -1.2.3.zip

As with 1.1, for the 1.2 code you'll need the 2012 build tools available from http://www.msextra.com/tools

James

EDIT: If you don't know what source is... this file isn't for you!

1uz_nissan · Post by **1uz_nissan** » Sat Jun 29, 2013 5:03 pm

Not sure the reason behind it, but with 1.2.3 beta, I get the finished files to flash. When I get 1.2.3 release, it's the source files.

93white3400z · Post by **93white3400z** » Sat Jun 29, 2013 5:36 pm

Compiled version is here: http://msextra.com/forums/viewtopic.php?f=131&t=50283

piledriver · Post by **piledriver** » Mon Jul 01, 2013 4:10 pm

Thank you shout out to the devs for posting the source.

thokes82 · Post by **thokes82** » Mon Sep 30, 2013 6:17 am

Hi there,

I have a question: Is it violating any license when I extend the Megaview output {a;0;6} and use some of the spare channels? My Problem is, that I own a Race Technology Dash 2 display and its Megasquirt adapter can only read serial Megaview channels (112byte). This is the Display: http://www.race-technology.com/dash2_8_940.html

This is my approach for serial.c mod:

Code: Select all

               if (compat < 2) {
                /* MS3 different from now */
                if (outpc.syncreason) {
                    outpc.syncreason = 0;       // send the sync loss reason code once then reset it
                }
            } else {
                x = 0xf003 + 72;
                GWR(outpc.EAEfcor1);
                GWR(outpc.egoV1);
                GWR(outpc.egoV2);
                g_write_generic(0, &x, 2); /* amc Updates */
                g_write_generic(0, &x, 2); /* kpaix */
                GWR(outpc.EAEfcor2);
                g_write_generic(outpc.sensors[0], &x, 2); /* Sensor 1 -> spare1 - Oil Pressure Sensor*/
                g_write_generic(outpc.sensors[1], &x, 2); /* Sensor 2 -> spare2 - Cylinder Head Temp*/
                g_write_generic(0, &x, 2); /* trigfix */
                g_write_generic(outpc.sensors[2], &x, 2); /* Sensor 3 -> spare4 - Oil Temp*/
                g_write_generic(0, &x, 2); /* spare5 */
                g_write_generic(0, &x, 2); /* spare6 */
                g_write_generic(0, &x, 2); /* spare7 */
                g_write_generic(0, &x, 2); /* spare8 */
                g_write_generic(0, &x, 2); /* spare9 */
                g_write_generic(0, &x, 2); /* spare10 */
                g_write_generic(0, &x, 2); /* tachcount */
                g_write_generic(0, &x, 2); /* ospare/cksum */
                g_write_generic(0, &x, 2); /* deltaT */
                g_write_generic(0, &x, 2); /* deltaT pt.2 */
            }

Please comment on my mod. regards, Thomas

Post by **jsmcortina** » Mon Sep 30, 2013 6:34 am

The LICENSE specifically allows this.
"You are permitted to modify the source code as you wish for use on your own MS3 card. Re-distribution of modified source or s19 is only allowed if first approved by James Murray and Kenneth Culver."

James

dancrev · Post by **dancrev** » Wed Nov 20, 2013 8:02 am

New here and just wondering... what is the typical schedule for source code to be released? I see the 1.2.4 binary release, but the latest source I can find is 1.2.3.

Thanks!
-Dan

Gerry-Austin · Post by **Gerry-Austin** » Sun Jan 05, 2014 6:42 pm

So I can't find the source code for the serial monitor anywhere. Am I missing it, or is all the source code not actually available for the MS3?
Thanks,
Gerry

Post by **jsmcortina** » Mon Jan 06, 2014 10:41 am

The source code for the MS3 firmware is available as per this topic.

The source code for the serial monitor is not and will not be available. The monitor comes pre-loaded on MS3 hardware and therefore the source is not needed to customise the firmware on the MS3.

James

vl-alexander · Post by **vl-alexander** » Sat Feb 15, 2014 10:35 pm

Hello. i want to add some custom feature to my ms3, only one source version that i find is 1.2.3.
But i cant figure out how to get it work. The problem is WRONG CODE LOADED?

Screenshot.png

Also, i have downloaded compiled 1.2.3 release, upload it to my MS, and got the same error.

How can i fix it, or, maybe find 1.2.4 source? 1.2.4 release works fine without this error.

Reverant · Post by **Reverant** » Sun Feb 16, 2014 2:52 am

http://www.msextra.com/forums/viewtopic ... 25&t=53004

In short, you have a newer MS3 board that doesn't support the 1.2.3 code, you need the code for 1.2.4.

vl-alexander · Post by **vl-alexander** » Sun Feb 16, 2014 4:37 am

Oh, i see. this problem really happens only with newly bought board..
I take another, older, ms3 from my garage and it was successfully flashed by modified firmware...

Anyway this is bad news, because i want my feature working on new boards too...

Meybe, after i finished, i should share my code, and hope that it will be included in official release?

The goal I'm working on, is rotary oil metering pump support.

Screenshot-omp.png

Post by **jsmcortina** » Sun Feb 16, 2014 5:06 am

I put up a patch for 1.2.3 to 1.2.4 source.

http://www.msextra.com/doc/ms3/files/so ... -patch.zip

James

vl-alexander · Post by **vl-alexander** » Sun Feb 16, 2014 6:18 am

Great, thanks!

Post by **muythaibxr** » Sun Feb 16, 2014 6:37 am

I already added th beginnings of OMP support with generic PID. I just have to add support for the stepper since our stepper controller can't handle the power requirements if the OMP. I would probably allow that part into the official code... The method I am using is closed loop... It doesn't look like that is what you are doing.

elaw · Post by **elaw** » Mon Mar 17, 2014 11:44 am

Does anyone feel like playing "help the dummy" and tell me what I'm doing wrong trying to mod this code?

I'm fooling around with the boost control code and want to create and use my own global variable.

So I added a declaration for it in ms3_vars.h:

Code: Select all

/* these were locally defined globals in ms3_misc.c */
extern long boost_ctl_last_pv[NUM_BOOST_CHANS][2];
extern long boost_ctl_last_error[NUM_BOOST_CHANS];
extern char boost_PID_enabled[NUM_BOOST_CHANS];
extern int boost_ctl_duty_100[NUM_BOOST_CHANS];
//EL ADDED
extern int boost_Integrator;
//EL ADDED END

And then tried to reference it in ms3_misc.c:

Code: Select all

	//EL (existing code) if we're just entering PID, init a few things
    if (!boost_PID_enabled[channel]) {
        flags |= PID_INIT;
        boost_PID_enabled[channel] = 1;
        boost_ctl_duty_100[channel] = boost_ctl_duty[channel] * 100;
//EL ADDED
        boost_Integrator = 0;
//EL ADDED END
    }

Before making the change in ms3_misc.c the code would compile - afterward I get an error in ms3_misc.c "undefined reference to 'boost_Integrator'". I've double-checked spelling and capitalization, made sure all files are saved, etc. but no luck.

There's a note in ms3_vars.h that says to "search for 'user defined' in ms3_main_decls.h for more notes" but I can't find anything helpful there - the word "user" doesn't even appear in that file!

What am I doing wrong?

bcrx7 · Post by **bcrx7** » Mon Mar 17, 2014 1:13 pm

Might want to read up on what extern does and what is required: http://www.geeksforgeeks.org/understand ... word-in-c/

Cheers,
O.

elaw wrote:Does anyone feel like playing "help the dummy" and tell me what I'm doing wrong trying to mod this code?

I'm fooling around with the boost control code and want to create and use my own global variable.

So I added a declaration for it in ms3_vars.h:
Code: Select all
/* these were locally defined globals in ms3_misc.c */
extern long boost_ctl_last_pv[NUM_BOOST_CHANS][2];
extern long boost_ctl_last_error[NUM_BOOST_CHANS];
extern char boost_PID_enabled[NUM_BOOST_CHANS];
extern int boost_ctl_duty_100[NUM_BOOST_CHANS];
//EL ADDED
extern int boost_Integrator;
//EL ADDED END
And then tried to reference it in ms3_misc.c:
Code: Select all
	//EL (existing code) if we're just entering PID, init a few things
    if (!boost_PID_enabled[channel]) {
        flags |= PID_INIT;
        boost_PID_enabled[channel] = 1;
        boost_ctl_duty_100[channel] = boost_ctl_duty[channel] * 100;
//EL ADDED
        boost_Integrator = 0;
//EL ADDED END
    }
Before making the change in ms3_misc.c the code would compile - afterward I get an error in ms3_misc.c "undefined reference to 'boost_Integrator'". I've double-checked spelling and capitalization, made sure all files are saved, etc. but no luck.

There's a note in ms3_vars.h that says to "search for 'user defined' in ms3_main_decls.h for more notes" but I can't find anything helpful there - the word "user" doesn't even appear in that file!

What am I doing wrong?

elaw · Post by **elaw** » Mon Mar 17, 2014 3:31 pm

Thanks! That helped me figure it out.

I thought it might be something like that, but I'd done a "find in files" in the source folder for one of the existing variables (figuring I'd use it as an example) but my search didn't find it anywhere else.

Well apparently I did something wrong because as soon as I added a declaration for my variable to ms3_main_vars.h, it compiled!

One thing that threw me off a little was a line at the top of ms3_vars.h that states "It is parsed to auto-generated ms3_main_vars.h" - that made me think that ms3_main_vars.h was somehow autogenerated and I shouldn't mess with it. But apparently that's not the case.

Post by **jsmcortina** » Mon Mar 17, 2014 3:43 pm

make clean
make

James

MWPau · Post by **MWPau** » Fri Mar 21, 2014 8:30 am

Any idea when we'll see the 1.3.0 code? If ever?

Megasquirt Support Forum (MSEXTRA)