CAN EGO: Add bits to define lamda state.

[Reverant]

The CAN EGO uses 10 of the 16 bits of the 2-byte CAN message. This means we have 6 spare bits that can be used to indicate the wideband's state.

May I propose:

1) Bit 10 = Warmup
2) Bit 11 = Normal operation
3) Bit 12 = Error
4) Bits 13,14,15 = Error number (Innovate goes up to error 8)

By parsin the bits above, the MS3 can then inhibit closed loop operation in warmup, and enter closed loop immediately when the sensor has warmed up, and if there's an error, stop closed loop operation and enter limp mode if configured.

Thoughts?

[racingmini_mtl]

The issue I see is backwards compatibility. If the CAN device sends those bits to an older MS3 firmware, that's going to create issues and it may not be obvious to diagnose. And that also means a way to turn this on and off on the CAN device for the same compatibility reason.

Jean

[Reverant]

Doesn't the MS3 firmware ignore any bits above 1023 on the CAN inputs, including the CAN ADCs?

[racingmini_mtl]

I'm not sure if it ignores the bits or simply uses 1023 if the value is above it. I'd need to check the code so I'll wait to see if James can answer.

Jean

[jsmcortina]

The handling is slightly different for each CAN wideband supported, but in the case of receiving Innovate data over CAN from an IOx the upper bits are not masked (currently), so anything there would be handled by:

Code: Select all

                        if (tmpadc > 1023) {
                            tmpadc = 1023;
                        }

James

[Reverant]

Ok, that seems a rather minor issue to me. Adding a configuration setting to the CAN device to send or not to send the bits is trivial. So can we add the extra bits?

[krisr]

What CAN based wideband are you using out of curiosity?

[Reverant]

What CAN based wideband are you using out of curiosity?

My own.