MS2/Extra 2.0 beta 16 (20071122)
Moderators: jsmcortina, muythaibxr
-
- Experienced MS/Extra'er
- Posts: 229
- Joined: Sun Apr 29, 2007 8:02 am
-
- Super MS/Extra'er
- Posts: 1021
- Joined: Sun Jun 27, 2004 12:04 pm
- Location: Long Beach, CA - USA
Ok, I think I see what's causing it. In this datalog, I held the throttle at around 2k rpm and every so often, DECEL is getting triggered, even though I have the slider all the way to the left and mapdot thresh set to 255. If I remember correctly, a DECEL event would cancel EGO correction, right?
Attached is a datalog. Any ideas what's up?
Thanks,
Mike
Attached is a datalog. Any ideas what's up?
Thanks,
Mike
-
- Super MS/Extra'er
- Posts: 1021
- Joined: Sun Jun 27, 2004 12:04 pm
- Location: Long Beach, CA - USA
Did some more testing
I put the accel slider bar all the way to the left, maxed out both map and tps thresholds (255 and 25.5 respectively) and set decel to 100%. And even though the slider is to the left (map), it is still using the TPS threshold for decel. Also another bug is that when I have the decel set to 100, the PW goes up upon a decel event! It takes a value of about 96% for decel to have about no change, but it's still reporting there is a decel event.
This bug is also in 1.0.2. I think the reason I wasn't see this problem as much with 1.0.2 was because I had the TPS lag set to 30, but I'd like to bring this up if possible.
I tested the msii v2.881 code and it also doesn't allow the TPS threshold to be increased past 25.5 and also sets the DECEL status even if the slider is to the left. The only difference is that it doesn't increase the PW when set to 100%.
I put the accel slider bar all the way to the left, maxed out both map and tps thresholds (255 and 25.5 respectively) and set decel to 100%. And even though the slider is to the left (map), it is still using the TPS threshold for decel. Also another bug is that when I have the decel set to 100, the PW goes up upon a decel event! It takes a value of about 96% for decel to have about no change, but it's still reporting there is a decel event.
This bug is also in 1.0.2. I think the reason I wasn't see this problem as much with 1.0.2 was because I had the TPS lag set to 30, but I'd like to bring this up if possible.
I tested the msii v2.881 code and it also doesn't allow the TPS threshold to be increased past 25.5 and also sets the DECEL status even if the slider is to the left. The only difference is that it doesn't increase the PW when set to 100%.
-
- Site Admin
- Posts: 8230
- Joined: Thu Oct 14, 2004 12:48 pm
-
- Super MS/Extra'er
- Posts: 1331
- Joined: Mon May 21, 2007 8:36 am
I've had a couple issues with PWM closed loop idle - mostly during warmup on colder days.
The first issue is it seems to completely ignore what I have in my target table - I don't know if this is a settings thing or what, but the highest target I have is 1200rpm, yet when it's warming up the idle is consistently 1300-1400rpm.
Here you can see my coolant temp is 50c, my warmup target is ~1080, but my idle is currently over 1300:
it does this consistently during warmup, but it's usually pretty close once it's up to operating temp.
The second issue, which I don't have a log for yet, is the PWM valve will seem to close and my idle will drop to ~300rpm (almost stalling). if I use the throttle it will come up, but the idle valve doesn't seem to want to activate. I never had this issue until beta 16, but it was warmer before then too. This usually happens when the coolant temp is halfway between cold and fully warmed up. if I can I'll get a log on the way home from work, but it doesn't always happen.
In case either of these is a settings issue, here are my PWM closed loop settings:
I have made some changes to the engine that require me to retune my PID settings, but it drives fine once it's warm and I haven't had the time to mess with it yet.
The first issue is it seems to completely ignore what I have in my target table - I don't know if this is a settings thing or what, but the highest target I have is 1200rpm, yet when it's warming up the idle is consistently 1300-1400rpm.
Here you can see my coolant temp is 50c, my warmup target is ~1080, but my idle is currently over 1300:
it does this consistently during warmup, but it's usually pretty close once it's up to operating temp.
The second issue, which I don't have a log for yet, is the PWM valve will seem to close and my idle will drop to ~300rpm (almost stalling). if I use the throttle it will come up, but the idle valve doesn't seem to want to activate. I never had this issue until beta 16, but it was warmer before then too. This usually happens when the coolant temp is halfway between cold and fully warmed up. if I can I'll get a log on the way home from work, but it doesn't always happen.
In case either of these is a settings issue, here are my PWM closed loop settings:
I have made some changes to the engine that require me to retune my PID settings, but it drives fine once it's warm and I haven't had the time to mess with it yet.
-
- Site Admin
- Posts: 8230
- Joined: Thu Oct 14, 2004 12:48 pm
hassmaschine:
Please PM me your email... I've made significant changes to the PWM idle code which I think will address your issues, and could use a third person "alpha-testing" them.
Basically, you'll have to completely retune your PID settings, but the end result will be much better control. KeithG has already tried the changes and had some success with them.
Ken
Please PM me your email... I've made significant changes to the PWM idle code which I think will address your issues, and could use a third person "alpha-testing" them.
Basically, you'll have to completely retune your PID settings, but the end result will be much better control. KeithG has already tried the changes and had some success with them.
Ken
-
- Super MS/Extra'er
- Posts: 1021
- Joined: Sun Jun 27, 2004 12:04 pm
- Location: Long Beach, CA - USA
could you change it such that a larger value can be used? You should be able to disabled accel enrichment. Right now both map and tps thresh use an unsigned char, but the map threshold isn't dividing it by 10 later...muythaibxr wrote:I'll have to take a look to see if Al changed any of that in 2.8xx. We're using the code as it was from 2.6xx, and didn't know of any bugs listed there.
I believe I did make it so the TPS value is limited to 25.5, I'll have to check the MAP value later.
Ken
also, you can't enter a larger value than 25.5 in the MSII code either, so the bug is carried over from Al's code...
-
- Site Admin
- Posts: 8230
- Joined: Thu Oct 14, 2004 12:48 pm
I can at least see how difficult it would be. IT will probably require some flash rearrangement in that page, which is sometimes easy (if there's any extra space) and sometimes not.
I could easily make the TPS threshold not divide by 10 later. I doubt that it's really necessary to set tpsDOT to .1%. MAP will probably have to be made an unsigned int.
It does seem a bit silly to have it so low.
Ken
I could easily make the TPS threshold not divide by 10 later. I doubt that it's really necessary to set tpsDOT to .1%. MAP will probably have to be made an unsigned int.
It does seem a bit silly to have it so low.
Ken
-
- Site Admin
- Posts: 8230
- Joined: Thu Oct 14, 2004 12:48 pm
closed loop
i'll try your dec 1 alpha tomorrow let you know my results
sean
sean
-
- Super MS/Extra'er
- Posts: 1021
- Joined: Sun Jun 27, 2004 12:04 pm
- Location: Long Beach, CA - USA
He wrote back and said it might be a simple INI change. I guess it all depends on what kinda resolution you guys want for the threshold (I asked that as well). I report back on what he says.muythaibxr wrote:Oh BTW, I don't think the 25.5/255 was a bug... I think Al did that on purpose.
Thanks!
Mike
-
- Super MS/Extra'er
- Posts: 1021
- Joined: Sun Jun 27, 2004 12:04 pm
- Location: Long Beach, CA - USA
Hey Ken,
Lance posted a reply saying the error was in the INI. There is also an illegal limit for MAPTHRESH so here is the corrected code for both:
Here is Lance's reply:
http://www.msefi.com/viewtopic.php?p=185125#185125
I will test to see if a value of decel=100% still causes an increase in PW.
thanks,
Mike
Lance posted a reply saying the error was in the INI. There is also an illegal limit for MAPTHRESH so here is the corrected code for both:
Code: Select all
tpsThresh = scalar, U08, 584, "%/sec", 1.00000, 0.00000, 0.00, 255, 0 ; * ( 1 byte)
mapThresh = scalar, U08, 585, "kPa/sec", 1.00000, 0.00000, 0.00, 255, 0 ; * ( 1 byte)
http://www.msefi.com/viewtopic.php?p=185125#185125
I will test to see if a value of decel=100% still causes an increase in PW.
thanks,
Mike
-
- Site Admin
- Posts: 8230
- Joined: Thu Oct 14, 2004 12:48 pm
-
- Super MS/Extra'er
- Posts: 1021
- Joined: Sun Jun 27, 2004 12:04 pm
- Location: Long Beach, CA - USA
EGO correction bug
Hey Ken,
Just wanted to make sure you saw this bug. Easy fix...
[edit]
helps if I post the link:
http://www.msextra.com/viewtopic.php?p=175550#175550
Just wanted to make sure you saw this bug. Easy fix...
[edit]
helps if I post the link:
http://www.msextra.com/viewtopic.php?p=175550#175550
-
- Super MS/Extra'er
- Posts: 1004
- Joined: Thu Feb 16, 2006 6:18 am
- Location: George, South Africa
-
- Super MS/Extra'er
- Posts: 1331
- Joined: Mon May 21, 2007 8:36 am