MS2/Extra Alpha 3.0.3 20090627 (was 20090623)

This is a forum for discussing the development and testing of alpha MS2/Extra code. Documentation
(Runs on MS2 and Microsquirt)

Moderators: jsmcortina, muythaibxr

Re: MS2/Extra Alpha 3.0.3 20090627 (was 20090623)

Postby warp21 » Mon Nov 02, 2009 11:06 am

This is what I was thinking.
warp21
Helpful MS/Extra'er
 
Posts: 69
Joined: Tue Oct 30, 2007 2:56 am

Re: MS2/Extra Alpha 3.0.3 20090627 (was 20090623)

Postby racingmini_mtl » Mon Nov 02, 2009 11:55 am

Yes, that's what I meant and that will work.

Jean
jbperf.com Main site . . . . . . . . . . . . . . . . . . . . . . jbperf.com Forum
Image
racingmini_mtl
Super MS/Extra'er
 
Posts: 6400
Joined: Sun May 02, 2004 6:51 am
Location: Quebec, Canada

Re: MS2/Extra Alpha 3.0.3 20090627 (was 20090623)

Postby SQLGUY » Sat Nov 07, 2009 12:01 pm

muythaibxr wrote:The code that didn't have the issue you're having is 2.1.0. I think I introduced the fix in the first 2.1.1. I do not know which 3.0.x to tell you to go back to to get that change out.

I believe I already have the fix worked in to 3.0.x, so the next 3.0.x release should have it fixed.

I'm working on merging a bunch of other stuff though, so no idea when the next 3.0.x will be released.

Ken


Hi Ken,

Can you give me more detail about this fix, or the fix itself, so I can build my own 3.0.3? This has been holding me up for the past few weeks and I'd like to move forward.

Looking at the ms2_extra_idle.c from 3.0.3h, it looks like the valve IS supposed to close when above RPM threshold (idle_closed_loop_throttlepressed)... something I was originally told was not the case - IIRC, I was told that, by design, no PWM changes took place beyond the threshold. Has this been changed? If so, I think I like the new direction. It makes more sense to me to have the valve closed based on the delay when above the threshold rather than returning to the cranking position or staying at the last position.

Looking at this code, though, I don't see why it's staying open at high RPM in 3.0.3h. Is it an issue with the PID lockout (flagbyte2 & flagbyte2_runidle)? Or is idle_closed_loop_throttlepressed not being called for some reason? ...oh, maybe I get it... THROTTLEPRESSED... is this occurring because cranking position revs high enough to get beyond the threshold and then, since TPS = 0 and RPM > threshold, neither idle_closed_loop_throttlepressed nor whatever other code should taper after cranking get called?

-----------EDIT-----------

I just diffed the 1.4 and 1.6 versions of ms2_extra_idle.c. The 1.6 version is the current one, the 1.4 version is what I was using, where I did not have these problems. The only significant differences I could see for regular CL operation were a new check for PID lockout based on RPMDOT, and, associated with that, a check for JUSTLIFTED. I am going to try playing around with the RPMDOT lockout setting to see if I can find a work around with the current code.

Thanks,
Paul
SQLGUY
Helpful MS/Extra'er
 
Posts: 119
Joined: Sun May 14, 2006 4:03 am
Location: Colorado Springs, CO

Re: MS2/Extra Alpha 3.0.3 20090627 (was 20090623)

Postby muythaibxr » Sat Nov 07, 2009 5:00 pm

Can you give me more detail about this fix, or the fix itself, so I can build my own 3.0.3? This has been holding me up for the past few weeks and I'd like to move forward.


I believe I've got it merged.

Looking at the ms2_extra_idle.c from 3.0.3h, it looks like the valve IS supposed to close when above RPM threshold (idle_closed_loop_throttlepressed)... something I was originally told was not the case - IIRC, I was told that, by design, no PWM changes took place beyond the threshold. Has this been changed? If so, I think I like the new direction. It makes more sense to me to have the valve closed based on the delay when above the threshold rather than returning to the cranking position or staying at the last position.


The code has had an option to close the valve when you press the throttle and the RPM goes above the threshold for quite some time. IT opens again every time you lift though. You just have to set the close delay to a non-zero number, and it'll close.

Looking at this code, though, I don't see why it's staying open at high RPM in 3.0.3h. Is it an issue with the PID lockout (flagbyte2 & flagbyte2_runidle)? Or is idle_closed_loop_throttlepressed not being called for some reason? ...oh, maybe I get it... THROTTLEPRESSED... is this occurring because cranking position revs high enough to get beyond the threshold and then, since TPS = 0 and RPM > threshold, neither idle_closed_loop_throttlepressed nor whatever other code should taper after cranking get called?

-----------EDIT-----------

I just diffed the 1.4 and 1.6 versions of ms2_extra_idle.c. The 1.6 version is the current one, the 1.4 version is what I was using, where I did not have these problems. The only significant differences I could see for regular CL operation were a new check for PID lockout based on RPMDOT, and, associated with that, a check for JUSTLIFTED. I am going to try playing around with the RPMDOT lockout setting to see if I can find a work around with the current code.

Thanks,
Paul


OK, I do have a fix in, so I'll see about doing a release of the 3.0.3 branch here shortly. Keep in mind that there are some things in there now that have not been tested in a car yet (ITB mode, MAF mode).

Ken
muythaibxr
Site Admin
 
Posts: 7397
Joined: Thu Oct 14, 2004 12:48 pm

Re: MS2/Extra Alpha 3.0.3 20090627 (was 20090623)

Postby SQLGUY » Sat Nov 07, 2009 7:40 pm

Hi Ken,

I don't have ITB's and I'm not currently running MAF, so, on the one hand I'm not worried about these, but on the other hand, I'm sorry I won't be able to provide any feedback for them.

Thanks for the help here.

Cheers,
Paul
SQLGUY
Helpful MS/Extra'er
 
Posts: 119
Joined: Sun May 14, 2006 4:03 am
Location: Colorado Springs, CO

Previous

Return to MS2/Extra Development

Who is online

Users browsing this forum: No registered users and 1 guest