Page 1 of 5

MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Mon Feb 27, 2012 9:29 am
by muythaibxr
Changes since last alpha:

- Backport average-based MAP sampling from MS3
- Merge latest gslender patch
- Slightly speed up ADC clock so conversion sequence time < 0.128ms
- Don't touch ADC0CTL registers after init (To avoid disrupting conversions)

The file can be found here:

http://www.msextra.com/doc/ms2extra/fil ... 120227.zip

Ken

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Mon Feb 27, 2012 9:58 am
by techsalvager
its a place to read whats included in the latest gslender patch?

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Mon Feb 27, 2012 2:02 pm
by gslender
techsalvager wrote:its a place to read whats included in the latest gslender patch?


Changes made from alpha release MS2/Extra 3.3.0a are as follows:

* added Dashpot Decay (adapted ms3 code, ini and valve-closed fixes)
* made changes to Idle Adaptive Advance ini to better align table axis
* added CL_Idle condition to idle adance (plus Manual added to allow old rpm/load/tps/clt method)
* improved Avg Sliding Window (thanks again Rob!) for PID RPM window smoothing + changed to function (allow reuse).
* added Cut Spark option to overrun fuel cut (allows super quick RPM drops).
* fixed ini bug for pwmidle_cl_initialvalues_duties (fix to bug in 3.3.0a)
* corrected idle code to use status2_pwmidle_closedloop for status2 in code
* changed idle code to use MS3 PWMIDLE_RESET states
* dashpot decay and idle status logs to Status4 and Status5 (respectively to help debug)
* changed PID values to pointers allowing immediate effect/change
* changed idle up duty adder and pid rpm window values to pointers allowing immediate effect/change
* changed dashpot duty and dashpot decay factor values to pointers allowing immediate effect/change
* changed idle advance and IVT tables to pointers allowing immediate effect/change
* fixed IVT bug when negative & changed to pointers (fix to bug in 3.3.0a)
* fixed bug and simplified clutch/neutral engagement (fix to bug in 3.3.0a)
* added new Feature - PWM idle adaptive voltage compensation (attempt to baseline voltage to allow changes from a lagged base)

Note that all Median filters are removed in Ken's release.

G

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Mon Feb 27, 2012 3:48 pm
by juansh2385
I can see that more input pins are available :yeah!:.
What pin are 5,6,7 in the cpu?

I can not see that name in the ms2 manual charts for identification of does i/o in particular.

Juan

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Mon Feb 27, 2012 5:02 pm
by gslender
juansh2385 wrote:I can see that more input pins are available :yeah!:.
What pin are 5,6,7 in the cpu?

I can not see that name in the ms2 manual charts for identification of does i/o in particular.

Juan


What are you talking about? :?

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Mon Feb 27, 2012 5:12 pm
by juansh2385
gslender wrote:
juansh2385 wrote:I can see that more input pins are available :yeah!:.
What pin are 5,6,7 in the cpu?

I can not see that name in the ms2 manual charts for identification of does i/o in particular.

Juan


What are you talking about? :?
G,

If you look at the in tuner studio in the idle input select tab you will see that there are more option to select now that include PA0 , 5,6 and 7. I am guessing 5,6,7 are for CAN but i am not sure so i asked.

Juan

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Mon Feb 27, 2012 5:37 pm
by jsmcortina
The problem is this:
Code: Select all
idle_up_options_input     =   bits, U08, 0, [1:3], "INVALID","PE0","PE1","INVALID","PA0"

There are 3 bits defined so there should be eight options, but there are actually only five. That's why "5", "6", "7" show up to fill in the missing ones.

James

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Mon Feb 27, 2012 10:16 pm
by gslender
jsmcortina wrote:The problem is this:
Code: Select all
idle_up_options_input     =   bits, U08, 0, [1:3], "INVALID","PE0","PE1","INVALID","PA0"

There are 3 bits defined so there should be eight options, but there are actually only five. That's why "5", "6", "7" show up to fill in the missing ones.

James


Thanks James - now that I'm looking at it, perhaps this is a better use of the bits...

Code: Select all
idle_up_options_input     =   bits, U08, 0, [1:2], "PE0","PE1","PA0","INVALID"

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Mon Feb 27, 2012 11:08 pm
by racingmini_mtl
Unless you have code that uses the 'INVALID' values for some other valid setting in other circumstances, there is no reason not to compact this on 2 bits. The usual reason something like that is used (in MS2/Extra) is for the different I/Os between the MS2 and the Microsquirt. You can still reserve the extra bit in the code for future use but not make it visible in the ini.

Jean

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Tue Feb 28, 2012 3:34 am
by jsmcortina
Something else that should be considered for the future is matching up all pin arrays like this, so that a common function can be used to handle them.
See ms3.ini and generic_port_setup in the MS3 source.

James

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Tue Feb 28, 2012 4:59 am
by gslender
jsmcortina wrote:Something else that should be considered for the future is matching up all pin arrays like this, so that a common function can be used to handle them.
See ms3.ini and generic_port_setup in the MS3 source.

James


Yep, saw that in the ms3 source... very cool way of dealing with inputs !! 8)

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Tue Feb 28, 2012 9:41 am
by muythaibxr
gslender wrote:
jsmcortina wrote:Something else that should be considered for the future is matching up all pin arrays like this, so that a common function can be used to handle them.
See ms3.ini and generic_port_setup in the MS3 source.

James


Yep, saw that in the ms3 source... very cool way of dealing with inputs !! 8)



It was a pretty good bit of work in MS3 to convert to that method too. That's the main reason why I didn't want to backport a lot of the ms3 features to ms2... the codebases are very different now and doing things in ms2 is comparatively much more painful than MS3 with the new port/pin and generic setup functions.

If we're switching to the same method in ms2, it will at least be easier to add features that use I/O.

Ken

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Wed Feb 29, 2012 10:00 am
by Monzsta
This ver. runs very well with my LS1. Haven't ran across any issues yet.

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Wed Feb 29, 2012 11:07 am
by mariob
Runs also very fine on my daily driver. The only problem is, that is impossible to start the car, when its warmed up and EAE is enabled. (bad oscillations - but this is nothing new and can be fixed with ~20 lines of code to fade in EAE gradually with afterstart)

The idle control is really a fine solution for very different needs.

Best Regards, Mario

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Wed Feb 29, 2012 2:49 pm
by gslender
There is a bug in one of my new features - PWM idle adaptive voltage compensation. So leave it off for now as it will cause bad IAC flapping. Fix is sorted.

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Wed Feb 29, 2012 9:01 pm
by ol boy
gslender wrote:
Note that all Median filters are removed in Ken's release.

G


Are you going to release a V2.3..something in the near future.. Your median filter has helped out my set up. Thanks Ryan

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Wed Feb 29, 2012 11:03 pm
by gslender
ol boy wrote:Are you going to release a V2.3..something in the near future.. Your median filter has helped out my set up. Thanks Ryan


Helped in what way?

G

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Thu Mar 01, 2012 11:29 am
by davcol
Ken was there anything been done to your code in aid for tps and map noise :?

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Thu Mar 01, 2012 12:39 pm
by muythaibxr
Not yet. There are plans to though.

The MAP noise should be significantly reduced for most people (if they notice a difference) from the new MAP sampling code.

We're planning on doing something along a similar line for TPS.

If there's still noise after those changes, we'll look at filters.

Ken

Re: MS2/extra alpha 3.3.0b (2012/02/27)

PostPosted: Thu Mar 01, 2012 8:06 pm
by ol boy
gslender wrote:
ol boy wrote:Are you going to release a V2.3..something in the near future.. Your median filter has helped out my set up. Thanks Ryan


Helped in what way?

G


I was able to get a steady RPM reading as my trigger wheel might not be as square and evenly spaced as needed. This also made tuning closed PID idle better with less up and down swinging. On the MAP side I got my load steady within one percent load range while idling.