MS2/Extra-release-3.4.2 BUG: AC indicator stays on

This is a forum for discussing the development and testing of alpha MS2/Extra code. Documentation
(Runs on MS2 and Microsquirt)

Moderators: jsmcortina, muythaibxr

MS2/Extra-release-3.4.2 BUG: AC indicator stays on

Postby jsdevel » Mon Oct 23, 2017 9:05 am

I've found what I believe to be a bug in this firmware version. I have AC idle up working properly i.e. the compressor cuts out when min rpm threshold is reached. I've noticed that the AC indicator light in TS stays on.

The relevant code in the idle_ac_idleup function is this:

if (outpc.rpm < flash12.ac_idleup_min_rpm) {
DISABLE_INTERRUPTS;
*port_ac_out &= ~pin_ac_out;
ENABLE_INTERRUPTS;
ac_time_since_last_on = 0;
return;
}


I noticed elsewhere in the idle_ac_idleup function how the indicator light was being switched off, so I updated the above code block as follows and now the AC indicator light cuts out when min rpm threshold has been reached:

if (outpc.rpm < flash12.ac_idleup_min_rpm) {
DISABLE_INTERRUPTS;
*port_ac_out &= ~pin_ac_out;
ENABLE_INTERRUPTS;
ac_time_since_last_on = 0;
outpc.status3 &= ~STATUS3_ACOUT;
return;
}
jsdevel
Experienced MS/Extra'er
 
Posts: 294
Joined: Mon May 23, 2016 3:41 pm
Location: Phoenix, AZ

Re: MS2/Extra-release-3.4.2 BUG: AC indicator stays on

Postby Blown88GT » Sun Dec 03, 2017 11:15 am

What is the status of this?
1988 Mustang GT, 57k miles, Orig. Owner
ProCharger 600B I/C, 12psi, FRPP Hdrs, Flwmstr F2, 3G Alt, Mk8 Fan & DCC, 3.55's, Prog Sprng, Subfrms, UCA, LCA, FCA, Tokico 5-way, CSA 16x8, Bridgestone RE760 225/50R16, Crane HI-6, Kirban FPR, MS2, DIYPNPF60, LC2, C&L76mm blo-thru MAF, 30lb FRPP
User avatar
Blown88GT
Master MS/Extra'er
 
Posts: 634
Joined: Sun Dec 15, 2013 7:53 pm
Location: South Florida


Return to MS2/Extra Development

Who is online

Users browsing this forum: No registered users and 1 guest