racingmini_mtl wrote:From a code stability, maintenance and support point of view, I don't think this is a good idea. Having a variable that can be either an 8-bit or 16-bit value depending on settings is asking for trouble. And this will have an impact on support due to user confusion among other things.
I'll let Ken and James chime in but as mentioned I don't think this is desirable even as a side project.
Jean - appreciate the fact you are taking the time to discuss this. Can you elaborate on those points above?
I can't see at all how it causes a configuration problem or a code issue with a byte either being used for 2-byte integer or 1-byte char... sure, if you switch between them (back and forth) the values will be garbage, but nothing too critical that isn't beyond what most people have to contend with when dealing with EFI and ensuring values are valid that don't harm the engine etc. It would also even be possible for TS and MS2 to coordinate the transfer of values safely by enabling a two-step config change whereby the ECU first prepares, and then copies the values between the tables to ensure nothing goes pear shaped. It would copy VE Table1 to HR Table in such a way that it copies-and-transfers the existing data as needed (and also on the way back from HR VE to 2x Table VE). If I do this correctly, I should be able to copy bytes in such a way that it preserves the low resolution VE values into the HR VE table, and back again (loosing resolution but maintaining non-10th values).
As for user confusion - I guess this would be all up to the provided TS instructions, the notes around the config screens, and warning notes to ensure all is understood. With the level of complexity MS2 is already at, I find it hard to believe this option would stump folks… or cause any more confusion than the mass of options that already exist?
Again, I'm just keen to understand the real technical barriers to proceeding - from all aspects as I understand the code, this is a relatively straight forward task to add 10th resolution to the main primary VE table (clobbering over the 2nd VE Table to do so).
I think everyone appreciates the desire to move all to MS3 for better features and reduce the development focus to a single architecture - but like everyone else, I'm just not prepared to ditch my recently purchased MS2 unit when there is plenty of capability left in the device.
Obviously if releasing a mod is going to have me banished, then I'll refrain, because as I understand the changed licensing, MS/Extra must approve any mod. So technically unless Ken, James or you Jean say it is OK to experiment, I'm not able to proceed - that would be dissappointing, but it is your right to do so.