Spark A is occurring when cylinder 4 is at TDC instead of 1

Testing and development of Megasquirt 3

Moderators: jsmcortina, muythaibxr

Re: Anyone (successfully) running 420A/Neon full sequential?

Postby opel » Sat May 05, 2012 11:55 am

I have scoped the engine to confirm that Spark A is firing when Cylinder #4 is at TDC. The problem has now been reproduced on another vehicle by SymTechLabs.

Channel #1 (red) is Cam signal
Channel #2 (yellow) is Spark A

Image
opel
Helpful MS/Extra'er
 
Posts: 88
Joined: Wed Jun 18, 2008 10:33 pm

Re: Spark A is occurring when cylinder 4 is at TDC instead o

Postby opel » Tue May 08, 2012 6:55 pm

Image
opel
Helpful MS/Extra'er
 
Posts: 88
Joined: Wed Jun 18, 2008 10:33 pm

Re: Spark A is occurring when cylinder 4 is at TDC instead o

Postby UnaClocker » Tue May 08, 2012 10:15 pm

If you can run the MS3 1.0.3 firmware, you can fix this yourself. Download the source, open "ms3_ign_wheel.c" in a text edittor, Find this section:
Code: Select all
   /* ----------------------  420A/NEON MODE ------------------------ */
    } else if (spkmode == 5) {
        flagbyte5 |= FLAGBYTE5_CRK_DOUBLE;

        deg_per_tooth[0] = 200;
        deg_per_tooth[1] = 200;
        deg_per_tooth[2] = 200;
        deg_per_tooth[3] = 1200;
        deg_per_tooth[4] = 200;
        deg_per_tooth[5] = 200;
        deg_per_tooth[6] = 200;
        deg_per_tooth[7] = 1200;

        smallest_tooth_crk = 60;        // now 6.0 deg, was 20.0 deg
        smallest_tooth_cam = 150;
        trigger_teeth[0] = 5;
        trig_angs[0] = -1110 + tmp_offset;      // 69 BTDC (on next event) = 111ATDC
        trig_angs[1] = -1110 + tmp_offset;      // 69 BTDC (on next event) = 111ATDC

        if (((ram4.spk_mode3 & 0xc0) == 0x80) || (ram4.spk_conf2 & 0x08)) {      //if COP mode or use cam then double up pattern
            flagbyte5 |= FLAGBYTE5_CAM;
            deg_per_tooth[8] = 200;
            deg_per_tooth[9] = 200;
            deg_per_tooth[10] = 200;
            deg_per_tooth[11] = 1200;
            deg_per_tooth[12] = 200;
            deg_per_tooth[13] = 200;
            deg_per_tooth[14] = 200;
            deg_per_tooth[15] = 1200;

            trigger_teeth[1] = 9;
            trigger_teeth[2] = 13;
            trigger_teeth[3] = 1;
            trig_angs[2] = -1110 + tmp_offset;  // 69 BTDC (on next event) = 111ATDC
            trig_angs[3] = -1110 + tmp_offset;  // 69 BTDC (on next event) = 111ATDC
            no_triggers = 4;
            no_teeth = 16;
            cycle_deg = 7200;
        } else {
            trigger_teeth[1] = 1;
            no_triggers = 2;
            no_teeth = 8;
        }
        last_tooth = no_teeth;

        if (num_cyl != 4) {
            conf_err = 17;
        }

Specifically, this part:
Code: Select all

            trigger_teeth[1] = 9;
            trigger_teeth[2] = 13;
            trigger_teeth[3] = 1;


James, feel free to correct me if I'm interpreting this wrong, but I think you need to change this section to:

Code: Select all
            trigger_teeth[0] = 13
            trigger_teeth[1] = 1;
            trigger_teeth[2] = 5;
            trigger_teeth[3] = 9;

Then simply recompile, and you should be golden. Me, I'd just change the wiring until your issue comes around on the to-do list..
Brian
'84 Dodge Rampage
User avatar
UnaClocker
Super MS/Extra'er
 
Posts: 1933
Joined: Fri May 07, 2004 12:59 pm
Location: Tacoma, WA

Re: Spark A is occurring when cylinder 4 is at TDC instead o

Postby jsmcortina » Wed May 09, 2012 2:35 am

If everyone is agreed that this change needs making, it will be done in the next beta firmware release.

James
I can supply, repair or upgrade Megasquirts in UK.

My Success story: viewtopic.php?f=104&t=34277
MSEXTRA documentation at: http://www.msextra.com/doc/index.html
jsmcortina
Site Admin
 
Posts: 28204
Joined: Mon May 03, 2004 1:34 am
Location: Birmingham, UK

Re: Spark A is occurring when cylinder 4 is at TDC instead o

Postby opel » Wed May 09, 2012 8:43 am

jsmcortina wrote:If everyone is agreed that this change needs making, it will be done in the next beta firmware release.

James


Thanks James,

Any chance you could send me a test firmware?

Thanks
opel
Helpful MS/Extra'er
 
Posts: 88
Joined: Wed Jun 18, 2008 10:33 pm

Re: Spark A is occurring when cylinder 4 is at TDC instead o

Postby opel » Thu May 10, 2012 7:42 am

UnaClocker wrote:If you can run the MS3 1.0.3 firmware, you can fix this yourself. Download the source, open "ms3_ign_wheel.c" in a text edittor, Find this section:
Code: Select all

            trigger_teeth[1] = 9;
            trigger_teeth[2] = 13;
            trigger_teeth[3] = 1;

James, feel free to correct me if I'm interpreting this wrong, but I think you need to change this section to:
Code: Select all
            trigger_teeth[0] = 13
            trigger_teeth[1] = 1;
            trigger_teeth[2] = 5;
            trigger_teeth[3] = 9;

Then simply recompile, and you should be golden. Me, I'd just change the wiring until your issue comes around on the to-do list..


Thanks! I will give this a shot
opel
Helpful MS/Extra'er
 
Posts: 88
Joined: Wed Jun 18, 2008 10:33 pm

Re: Spark A is occurring when cylinder 4 is at TDC instead o

Postby SymTech Laboratories » Thu May 10, 2012 10:24 am

jsmcortina wrote:If everyone is agreed that this change needs making, it will be done in the next beta firmware release.

Per our PM's, this does seem like a change that needs to be made. Thanks!
SymTech Laboratories, LLC ----- MSQ File Repository: megasquirt.symtechlabs.com
Image
SymTech Laboratories
Super MS/Extra'er
 
Posts: 2188
Joined: Sun Aug 31, 2008 4:02 pm
Location: South Florida, USA

Re: Spark A is occurring when cylinder 4 is at TDC instead o

Postby juansh2385 » Mon May 14, 2012 5:16 am

Hey James could this also affect the sequential injection order for this code?

Please correct me if I am wrong but I notice that ms2 have the same code in the 420a wheel decoder does this mean that ms2 is also affected by this?

Juan
juansh2385
Master MS/Extra'er
 
Posts: 482
Joined: Fri Feb 25, 2011 4:28 pm

Re: Spark A is occurring when cylinder 4 is at TDC instead o

Postby jsmcortina » Mon May 14, 2012 6:55 am

As MS2 is using the same code then the result is the same yes.

James
I can supply, repair or upgrade Megasquirts in UK.

My Success story: viewtopic.php?f=104&t=34277
MSEXTRA documentation at: http://www.msextra.com/doc/index.html
jsmcortina
Site Admin
 
Posts: 28204
Joined: Mon May 03, 2004 1:34 am
Location: Birmingham, UK

Re: Spark A is occurring when cylinder 4 is at TDC instead o

Postby juansh2385 » Mon May 14, 2012 8:44 am

edit* (it sounded as if was saying that the code is the reason when is not )

I am running sequential injection and waste spark ign so its harder for me to notice if the injection is out of phase too, but I am assuming that if the both injection and ignition are affected by this. I am going to scope my car to see if in my car injection 1 is out of phase and report back.

Thanks.

Juan
Last edited by juansh2385 on Mon May 14, 2012 9:29 am, edited 1 time in total.
juansh2385
Master MS/Extra'er
 
Posts: 482
Joined: Fri Feb 25, 2011 4:28 pm

Re: Spark A is occurring when cylinder 4 is at TDC instead o

Postby racingmini_mtl » Mon May 14, 2012 9:22 am

The injection will have the same phase as the ignition. However, having an out of phase injection will not melt a piston but at worse would mean a rougher running engine.

Jean
jbperf.com Main site . . . . . . . . . . . . . . . . . . . . . . jbperf.com Forum
Image
racingmini_mtl
Super MS/Extra'er
 
Posts: 6530
Joined: Sun May 02, 2004 6:51 am
Location: Quebec, Canada

Re: Spark A is occurring when cylinder 4 is at TDC instead o

Postby juansh2385 » Mon May 14, 2012 9:27 am

Jean I also agree with you that the melted piston is not fault of the code it is probably a bad in a injector or something like that but i am sure that bad phase does not help. Any ways thanks for the help as always. I will report back if I can confirm also that my car is out of phase.

Juan
juansh2385
Master MS/Extra'er
 
Posts: 482
Joined: Fri Feb 25, 2011 4:28 pm

Re: Spark A is occurring when cylinder 4 is at TDC instead o

Postby opel » Thu May 24, 2012 11:37 am

Any chance for a test firmware soon? I want to finalize my wiring, need to get to the racetrack someday. (please :) :) )
opel
Helpful MS/Extra'er
 
Posts: 88
Joined: Wed Jun 18, 2008 10:33 pm

Re: Spark A is occurring when cylinder 4 is at TDC instead o

Postby turbodoug » Sat May 26, 2012 9:05 pm

I was able to duplicate this issue as well. Good find!

Both spark and fuel were out of phase.

This was fixed in the most recent code version "pre1.1beta22". I've tested this code on the bench as well as on the car and the spark/fuel phase is now correct.
Doug
turbodoug
Helpful MS/Extra'er
 
Posts: 46
Joined: Thu Nov 25, 2004 7:02 pm
Location: Nashville, TN

Re: Spark A is occurring when cylinder 4 is at TDC instead o

Postby opel » Mon May 28, 2012 1:23 pm

OK - it looks right on the scope, I will wire up my car and see how it runs. Thank you for the fix!!!

Image
opel
Helpful MS/Extra'er
 
Posts: 88
Joined: Wed Jun 18, 2008 10:33 pm

Re: Spark A is occurring when cylinder 4 is at TDC instead o

Postby opel » Mon May 28, 2012 9:15 pm

It works! Car is up and running and idle is smoother than ever!
opel
Helpful MS/Extra'er
 
Posts: 88
Joined: Wed Jun 18, 2008 10:33 pm

Re: Spark A is occurring when cylinder 4 is at TDC instead o

Postby juansh2385 » Tue May 29, 2012 8:38 am

Great to know James is the fix that you implemented the same as the one that was presented here? I want to try it in my ms2.

Juan
juansh2385
Master MS/Extra'er
 
Posts: 482
Joined: Fri Feb 25, 2011 4:28 pm

Previous

Return to MS3 Development

Who is online

Users browsing this forum: No registered users and 0 guests